On Fri, Feb 07, 2020 at 03:26:46PM -0500, Vivek Goyal wrote:
> +static blk_status_t pmem_do_bvec(struct pmem_device *pmem, struct page *page,
> + unsigned int len, unsigned int off, unsigned int op,
> + sector_t sector)
> +{
> + if (!op_is_write(op))
> + return pmem_do_read(pmem, page, off, sector, len);
> +
> + return pmem_do_write(pmem, page, off, sector, len);
Why not:
if (op_is_write(op))
return pmem_do_write(pmem, page, off, sector, len);
return pmem_do_read(pmem, page, off, sector, len);
that being said I don't see the point of this pmem_do_bvec helper given
that it only has two callers.
The rest looks good to me.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
