Vishal Verma <[email protected]> writes: > A toolchain update in Fedora 32 caused new compile errors due to > multiple definitions of dimm_ops structures. The declarations in > 'private.h' for the various NFIT families are present so that libndctl > can find all the per-family dimm-ops. However they need to be declared > as extern because the actual definitions are in <family>.c > > Cc: Dan Williams <[email protected]> > Suggested-by: Dan Williams <[email protected]> > Signed-off-by: Vishal Verma <[email protected]> > --- > ndctl/lib/private.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ndctl/lib/private.h b/ndctl/lib/private.h > index e445301..16bf8f9 100644 > --- a/ndctl/lib/private.h > +++ b/ndctl/lib/private.h > @@ -343,10 +343,10 @@ struct ndctl_dimm_ops { > int (*xlat_firmware_status)(struct ndctl_cmd *); > }; > > -struct ndctl_dimm_ops * const intel_dimm_ops; > -struct ndctl_dimm_ops * const hpe1_dimm_ops; > -struct ndctl_dimm_ops * const msft_dimm_ops; > -struct ndctl_dimm_ops * const hyperv_dimm_ops; > +extern struct ndctl_dimm_ops * const intel_dimm_ops; > +extern struct ndctl_dimm_ops * const hpe1_dimm_ops; > +extern struct ndctl_dimm_ops * const msft_dimm_ops; > +extern struct ndctl_dimm_ops * const hyperv_dimm_ops; > > static inline struct ndctl_bus *cmd_to_bus(struct ndctl_cmd *cmd) > {
Acked-by: Jeff Moyer <[email protected]> _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
