> -----Original Message----- > From: Baoquan He <[email protected]> > Sent: Wednesday, 26 February 2020 7:15 PM > To: Alastair D'Silva <[email protected]> > Cc: [email protected]; Aneesh Kumar K . V > <[email protected]>; Oliver O'Halloran <[email protected]>; > Benjamin Herrenschmidt <[email protected]>; Paul Mackerras > <[email protected]>; Michael Ellerman <[email protected]>; Frederic > Barrat <[email protected]>; Andrew Donnellan <[email protected]>; > Arnd Bergmann <[email protected]>; Greg Kroah-Hartman > <[email protected]>; Dan Williams <[email protected]>; > Vishal Verma <[email protected]>; Dave Jiang > <[email protected]>; Ira Weiny <[email protected]>; Andrew Morton > <[email protected]>; Mauro Carvalho Chehab > <[email protected]>; David S. Miller <[email protected]>; > Rob Herring <[email protected]>; Anton Blanchard <[email protected]>; > Krzysztof Kozlowski <[email protected]>; Mahesh Salgaonkar > <[email protected]>; Madhavan Srinivasan > <[email protected]>; Cédric Le Goater <[email protected]>; Anju T > Sudhakar <[email protected]>; Hari Bathini > <[email protected]>; Thomas Gleixner <[email protected]>; Greg > Kurz <[email protected]>; Nicholas Piggin <[email protected]>; Masahiro > Yamada <[email protected]>; Alexey Kardashevskiy > <[email protected]>; [email protected]; linuxppc- > [email protected]; [email protected]; [email protected] > Subject: Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs > > On 02/21/20 at 02:26pm, Alastair D'Silva wrote: > > From: Alastair D'Silva <[email protected]> > > > > Function declarations don't need externs, remove the existing ones so > > they are consistent with newer code > > > > Signed-off-by: Alastair D'Silva <[email protected]> > > --- > > arch/powerpc/include/asm/pnv-ocxl.h | 32 ++++++++++++++--------------- > > include/misc/ocxl.h | 6 +++--- > > 2 files changed, 18 insertions(+), 20 deletions(-) > > > > diff --git a/arch/powerpc/include/asm/pnv-ocxl.h > > b/arch/powerpc/include/asm/pnv-ocxl.h > > index 0b2a6707e555..b23c99bc0c84 100644 > > --- a/arch/powerpc/include/asm/pnv-ocxl.h > > +++ b/arch/powerpc/include/asm/pnv-ocxl.h > > @@ -9,29 +9,27 @@ > > #define PNV_OCXL_TL_BITS_PER_RATE 4 > > #define PNV_OCXL_TL_RATE_BUF_SIZE > ((PNV_OCXL_TL_MAX_TEMPLATE+1) * PNV_OCXL_TL_BITS_PER_RATE / 8) > > > > -extern int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 > *enabled, > > - u16 *supported); > > It works w or w/o extern when declare functions. Searching 'extern' > under include can find so many functions with 'extern' adding. Do we have a > explicit standard if we should add or remove 'exter' in function declaration? > > I have no objection to this patch, just want to make clear so that I can handle > it w/o confusion. > > Thanks > Baoquan >
For the OpenCAPI driver, we have settled on not having 'extern' on functions. I don't think I've seen a standard that supports or refutes this, but it does not value add. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: [email protected] blog: http://alastair.d-silva.org Twitter: @EvilDeece _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
