On Sat 29-02-20 12:22:28, Dan Williams wrote:
> While there are some tests that require the new "dax-bus" device model,
> none of the tests require compatibility mode. Drop the requirement so
> the tests work with DEV_DAX_PMEM_COMPAT=n kernels.
>
> Link: http://lore.kernel.org/r/[email protected]
> Cc: Jan Kara <[email protected]>
> Signed-off-by: Dan Williams <[email protected]>
The patch looks good to me. Thanks for fixing this! I just have to say that
the strstr(3) usage in this function looks rather unusual to me. Why not
just strcmp(3)?
Honza
> ---
> test/core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/test/core.c b/test/core.c
> index 888f5d8c0e42..dff842a9f378 100644
> --- a/test/core.c
> +++ b/test/core.c
> @@ -180,6 +180,14 @@ int nfit_test_init(struct kmod_ctx **ctx, struct
> kmod_module **mod,
>
> retry:
> rc = kmod_module_new_from_name(*ctx, name, mod);
> +
> + /*
> + * dax_pmem_compat is not required, missing is ok,
> + * present-but-production is not ok.
> + */
> + if (rc && strstr(name, "dax_pmem_compat"))
> + continue;
> +
> if (rc) {
> log_err(&log_ctx, "%s.ko: missing\n", name);
> break;
>
--
Jan Kara <[email protected]>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
