Add a 'destroy-device' command which destroys a
dax device. Like namespaces, the device needs to
be disabled in order to be destroyed. Example usage:
$ daxctl disable-device dax0.1
disabled 1 device
$ daxctl destroy-device dax0.1
destroyed 1 device
Signed-off-by: Joao Martins <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
---
daxctl/builtin.h | 1 +
daxctl/daxctl.c | 1 +
daxctl/device.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 68 insertions(+)
diff --git a/daxctl/builtin.h b/daxctl/builtin.h
index 19b33933b91b..29ba63ca17aa 100644
--- a/daxctl/builtin.h
+++ b/daxctl/builtin.h
@@ -7,6 +7,7 @@ struct daxctl_ctx;
int cmd_list(int argc, const char **argv, struct daxctl_ctx *ctx);
int cmd_migrate(int argc, const char **argv, struct daxctl_ctx *ctx);
int cmd_create_device(int argc, const char **argv, struct daxctl_ctx *ctx);
+int cmd_destroy_device(int argc, const char **argv, struct daxctl_ctx *ctx);
int cmd_reconfig_device(int argc, const char **argv, struct daxctl_ctx *ctx);
int cmd_disable_device(int argc, const char **argv, struct daxctl_ctx *ctx);
int cmd_enable_device(int argc, const char **argv, struct daxctl_ctx *ctx);
diff --git a/daxctl/daxctl.c b/daxctl/daxctl.c
index 1f315168c513..bd5539900391 100644
--- a/daxctl/daxctl.c
+++ b/daxctl/daxctl.c
@@ -72,6 +72,7 @@ static struct cmd_struct commands[] = {
{ "help", .d_fn = cmd_help },
{ "migrate-device-model", .d_fn = cmd_migrate },
{ "create-device", .d_fn = cmd_create_device },
+ { "destroy-device", .d_fn = cmd_destroy_device },
{ "reconfigure-device", .d_fn = cmd_reconfig_device },
{ "online-memory", .d_fn = cmd_online_memory },
{ "offline-memory", .d_fn = cmd_offline_memory },
diff --git a/daxctl/device.c b/daxctl/device.c
index c038abba8063..05293d6c38ee 100644
--- a/daxctl/device.c
+++ b/daxctl/device.c
@@ -52,6 +52,7 @@ enum device_action {
ACTION_CREATE,
ACTION_DISABLE,
ACTION_ENABLE,
+ ACTION_DESTROY,
};
#define BASE_OPTIONS() \
@@ -69,6 +70,10 @@ OPT_BOOLEAN('f', "force", ¶m.force, \
#define CREATE_OPTIONS() \
OPT_STRING('s', "size", ¶m.size, "size", "size to switch the device to")
+#define DESTROY_OPTIONS() \
+OPT_BOOLEAN('f', "force", ¶m.force, \
+ "attempt to disable before destroying device")
+
#define ZONE_OPTIONS() \
OPT_BOOLEAN('\0', "no-movable", ¶m.no_movable, \
"online memory in ZONE_NORMAL")
@@ -110,6 +115,12 @@ static const struct option enable_options[] = {
OPT_END(),
};
+static const struct option destroy_options[] = {
+ BASE_OPTIONS(),
+ DESTROY_OPTIONS(),
+ OPT_END(),
+};
+
static const char *parse_device_options(int argc, const char **argv,
enum device_action action, const struct option *options,
const char *usage, struct daxctl_ctx *ctx)
@@ -144,6 +155,9 @@ static const char *parse_device_options(int argc, const
char **argv,
case ACTION_ENABLE:
action_string = "enable";
break;
+ case ACTION_DESTROY:
+ action_string = "destroy";
+ break;
default:
action_string = "<>";
break;
@@ -199,6 +213,7 @@ static const char *parse_device_options(int argc, const
char **argv,
if (param.no_movable)
mem_zone = MEM_ZONE_NORMAL;
/* fall through */
+ case ACTION_DESTROY:
case ACTION_OFFLINE:
case ACTION_DISABLE:
case ACTION_ENABLE:
@@ -364,6 +379,35 @@ static int dev_resize(struct daxctl_dev *dev, unsigned
long long val)
return 0;
}
+static int dev_destroy(struct daxctl_dev *dev)
+{
+ const char *devname = daxctl_dev_get_devname(dev);
+ int rc;
+
+ if (daxctl_dev_is_enabled(dev) && !param.force) {
+ fprintf(stderr, "%s is active, specify --force for deletion\n",
+ devname);
+ return -ENXIO;
+ } else {
+ rc = daxctl_dev_disable(dev);
+ if (rc) {
+ fprintf(stderr, "%s: disable failed: %s\n",
+ daxctl_dev_get_devname(dev), strerror(-rc));
+ return rc;
+ }
+ }
+
+ rc = daxctl_dev_set_size(dev, 0);
+ if (rc < 0)
+ return rc;
+
+ rc = daxctl_region_destroy_dev(daxctl_dev_get_region(dev), dev);
+ if (rc < 0)
+ return rc;
+
+ return 0;
+}
+
static int disable_devdax_device(struct daxctl_dev *dev)
{
struct daxctl_memory *mem = daxctl_dev_get_memory(dev);
@@ -689,6 +733,11 @@ static int do_xaction_device(const char *device, enum
device_action action,
if (rc == 0)
(*processed)++;
break;
+ case ACTION_DESTROY:
+ rc = dev_destroy(dev);
+ if (rc == 0)
+ (*processed)++;
+ break;
default:
rc = -EINVAL;
break;
@@ -725,6 +774,23 @@ int cmd_create_device(int argc, const char **argv, struct
daxctl_ctx *ctx)
return rc;
}
+int cmd_destroy_device(int argc, const char **argv, struct daxctl_ctx *ctx)
+{
+ char *usage = "daxctl destroy-device <device> [<options>]";
+ const char *device = parse_device_options(argc, argv, ACTION_DESTROY,
+ destroy_options, usage, ctx);
+ int processed, rc;
+
+ rc = do_xaction_device(device, ACTION_DESTROY, ctx, &processed);
+ if (rc < 0)
+ fprintf(stderr, "error destroying devices: %s\n",
+ strerror(-rc));
+
+ fprintf(stderr, "destroyed %d device%s\n", processed,
+ processed == 1 ? "" : "s");
+ return rc;
+}
+
int cmd_reconfig_device(int argc, const char **argv, struct daxctl_ctx *ctx)
{
char *usage = "daxctl reconfigure-device <device> [<options>]";
--
2.17.1
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
