On 4/18/20 3:20 PM, Bart Van Assche wrote:
> On 4/18/20 11:41 AM, Randy Dunlap wrote:
>> --- linux-next-20200327.orig/include/linux/kernel.h
>> +++ linux-next-20200327/include/linux/kernel.h
>> @@ -40,6 +40,14 @@
>> #define READ 0
>> #define WRITE 1
>> +/*
>> + * When using -Wextra, an "if" statement followed by an empty block
>> + * (containing only a ';'), produces a warning from gcc:
>> + * warning: suggest braces around empty body in an ‘if’ statement
>> [-Wempty-body]
>> + * Replace the empty body with do_empty() to silence this warning.
>> + */
>> +#define do_empty() do { } while (0)
>> +
>> /**
>> * ARRAY_SIZE - get the number of elements in array @arr
>> * @arr: array to be sized
>
> I'm less than enthusiast about introducing a new macro to suppress "empty
> body" warnings. Anyone who encounters code in which this macro is used will
> have to look up the definition of this macro to learn what it does. Has it
> been considered to suppress empty body warnings by changing the empty bodies
> from ";" into "{}"?
I mentioned that possibility in PATCH 0/9 (cover letter)...
which should have been RFC PATCH 0/9.
So yes, it is possible.
You are the only other person who has mentioned it.
thanks.
--
~Randy
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
