On Wed, May 27, 2020 at 12:24 PM Dan Williams <[email protected]> wrote: [..] > > This was done by adding two new dimm-ops callbacks that were > > implemented by the papr_scm implementation within libndctl. These > > callbacks are invoked by newly introduce code in 'util/json-smart.c' > > that format the returned stats from these new dimm-ops and transform > > them into a json-object to later presentation. I would request you to > > look at RFC patch-set[2] to understand the implementation details. > > I'm ok to add some stats to ndctl, but I want ndctl to be limited to > general statistics and not performance counters. Performance counters > and performance events should be abstracted through perf where > possible.
Another aspect that helps common statistics is to expose them in sysfs. I'm going to go review your proposed ioctl mechanism, but I would hope that is reserved for multi-field command payloads that need to be sent as a unit rather than statistics retrieval that is amenable to a sysfs interface. _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
