On Tue, Jul 07, 2020 at 10:16:35PM +0530, Harish wrote: > Patch fixes checking output filter option (-o <file> or -c) of > write-infoblock command to be mutually exclusive. > > Signed-off-by: Harish <[email protected]>
Looks reasonable to me. Reviewed-by: Ira Weiny <[email protected]> > --- > ndctl/namespace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ndctl/namespace.c b/ndctl/namespace.c > index 0550580..d3ade25 100644 > --- a/ndctl/namespace.c > +++ b/ndctl/namespace.c > @@ -440,7 +440,7 @@ static const char *parse_namespace_options(int argc, > const char **argv, > rc = -EINVAL; > } > > - if (action == ACTION_WRITE_INFOBLOCK && (param.outfile || param.std_out) > + if (action == ACTION_WRITE_INFOBLOCK && (param.outfile && param.std_out) > && argc) { > error("specify only one of a namespace filter, --output, or > --stdout\n"); > rc = -EINVAL; > -- > 2.26.2 > _______________________________________________ > Linux-nvdimm mailing list -- [email protected] > To unsubscribe send an email to [email protected] _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
