Vishal Verma <[email protected]> writes: <snip> >> static int papr_xlat_firmware_status(struct ndctl_cmd *cmd) >> { >> - const struct nd_pkg_pdsm *pcmd = to_pdsm(cmd); >> - >> - return pcmd->cmd_status; >> + return (cmd->type == ND_CMD_CALL) ? to_pdsm(cmd)->cmd_status : 0; > > Is this correct? -- for non ND_CMD_CALL commands this will always return a 0, > and it seems like you will lose any error state for commands > like ND_CMD_SET_CONFIG_DATA. This behaviour is similar to what ndctl_cmd_xlat_firmware_status() does when corresponding dimm-ops are missing the 'xlat_firmware_status' callback.
Also ndctl_cmd_submit_xlat() returns the rc from ndctl_cmd_submit() in case ndctl_cmd_xlat_firmware_status() returns '0', which corresponds to 'ndctl_cmd.status' field. So any error codes returned from ndctl_cmd_submit() are still returned back to the caller even though papr_xlat_firmware_status() returned '0'. > >> } >> >> /* Verify if the given command is supported and valid */ > > -- Cheers ~ Vaibhav _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
