On Thu, Oct 29, 2020 at 7:29 PM Dan Williams <[email protected]> wrote: > > The core-mm has a default __weak implementation of phys_to_target_node() > when the architecture does not override it. That symbol is exported > for modules. However, while the export in mm/memory_hotplug.c exported > the symbol in the configuration cases of: > > CONFIG_NUMA_KEEP_MEMINFO=y > CONFIG_MEMORY_HOTPLUG=y > > ...and: > > CONFIG_NUMA_KEEP_MEMINFO=n > CONFIG_MEMORY_HOTPLUG=y > > ...it failed to export the symbol in the case of: > > CONFIG_NUMA_KEEP_MEMINFO=y > CONFIG_MEMORY_HOTPLUG=n > > Always export the symbol from the CONFIG_NUMA_KEEP_MEMINFO section of > arch/x86/mm/numa.c, and teach mm/memory_hotplug.c to optionally export > in case arch/x86/mm/numa.c has already performed the export. > > The dependency on NUMA_KEEP_MEMINFO for DEV_DAX_HMEM_DEVICES is invalid > now that the symbol is properly exported in all combinations of > CONFIG_NUMA_KEEP_MEMINFO and CONFIG_MEMORY_HOTPLUG. Note that in the > CONFIG_NUMA=n case no export is needed since their is a dummy static > inline implementation of phys_to_target_node() in that case. > > Reported-by: Randy Dunlap <[email protected]> > Reported-by: Thomas Gleixner <[email protected]> > Reported-by: kernel test robot <[email protected]> > Fixes: a035b6bf863e ("mm/memory_hotplug: introduce default > phys_to_target_node() implementation") > Cc: Joao Martins <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: [email protected] > Cc: Vishal Verma <[email protected]> > Signed-off-by: Dan Williams <[email protected]>
Thomas, do you want to ack this so Andrew can pick it up, or I can take it through as a device-dax update, but either way the diffstat warrants x86 + mm acks. _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
