Micron Confidential
From: Dan Williams <dan.j.willi...@intel.com> Date: Monday, February 1, 2021 at 1:28 PM To: Ben Widawsky <ben.widaw...@intel.com> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>, linux-...@vger.kernel.org <linux-...@vger.kernel.org>, Linux ACPI <linux-a...@vger.kernel.org>, Linux Kernel Mailing List <linux-ker...@vger.kernel.org>, linux-nvdimm <linux-nvdimm@lists.01.org>, Linux PCI <linux-...@vger.kernel.org>, Bjorn Helgaas <helg...@kernel.org>, Chris Browy <cbr...@avery-design.com>, Christoph Hellwig <h...@infradead.org>, Ira Weiny <ira.we...@intel.com>, Jon Masters <j...@jonmasters.org>, Jonathan Cameron <jonathan.came...@huawei.com>, Rafael Wysocki <rafael.j.wyso...@intel.com>, Randy Dunlap <rdun...@infradead.org>, Vishal Verma <vishal.l.ve...@intel.com>, daniel....@alibaba-inc.com <daniel....@alibaba-inc.com>, John Groves (jgroves) <jgro...@micron.com>, Kelley, Sean V <sean.v.kel...@intel.com> Subject: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless you recognize the sender and were expecting this message. On Mon, Feb 1, 2021 at 11:13 AM Ben Widawsky <ben.widaw...@intel.com> wrote: > > On 21-02-01 12:54:00, Konrad Rzeszutek Wilk wrote: > > > +#define cxl_doorbell_busy(cxlm) > > > \ > > > + (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET) & > > > \ > > > + CXLDEV_MB_CTRL_DOORBELL) > > > + > > > +#define CXL_MAILBOX_TIMEOUT_US 2000 > > > > You been using the spec for the values. Is that number also from it ? > > > > Yes it is. I'll add a comment with the spec reference. >From section 8.2.8.4 in the CXL 2.0 spec: “The mailbox command timeout is 2 >seconds.” So this should be: #define CXL_MAILBOX_TIMEOUT_US 2000000 …right? 2000us is 2ms… [snip] Micron Confidential _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
