> > Hi QI, > > QI Fuli <[email protected]> writes: > > > Due to the lack of jq command, the result of the test will be 'fail'. > > This patch adds checking the presence of jq commmand ahead. > > If there is no jq command in the system, the test will be marked as 'skip'. > > > > Signed-off-by: QI Fuli <[email protected]> > > Link: https://github.com/pmem/ndctl/issues/141 > > Could this dependency be made part of configure.ac? Something like > > diff --git a/configure.ac b/configure.ac index 5ec8d2f..0f2c6c1 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -65,6 +65,13 @@ fi > AC_SUBST([XMLTO]) > fi > > +AC_CHECK_PROG(JQ, [jq], [$(which jq)], [missing]) if test "x$JQ" = > +xmissing; then > + AC_MSG_ERROR([jq needed to validate tests]) fi > +AC_SUBST([JQ]) > + > + > AC_C_TYPEOF > AC_DEFINE([HAVE_STATEMENT_EXPR], 1, [Define to 1 if you have statement > expressions.]) > > Thanks, > Santosh
Hi Santosh, Thank you very much for the comments. Yes, making this dependency part of configure.ac sounds good. Meanwhile I think the tests should be improved, because the test result should not be "fail" if there is no jq command in the system. I will make a V2 patch. Best, QI _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
