On Fri, May 7, 2021 at 5:17 AM Dan Williams <[email protected]> wrote: > > On Thu, May 6, 2021 at 10:28 AM Kaneda, Erik <[email protected]> wrote: > > > > > > > > > -----Original Message----- > > > From: Yi Zhang <[email protected]> > > > Sent: Wednesday, May 5, 2021 8:05 PM > > > To: Williams, Dan J <[email protected]>; Moore, Robert > > > <[email protected]> > > > Cc: linux-nvdimm <[email protected]>; Kaneda, Erik > > > <[email protected]>; Wysocki, Rafael J <[email protected]> > > > Subject: Re: [bug report] system panic at nfit_get_smbios_id+0x6e/0xf0 > > > [nfit] during boot > > > > > > On Sat, May 1, 2021 at 2:05 PM Dan Williams <[email protected]> > > > wrote: > > > > > > > > On Fri, Apr 30, 2021 at 7:28 PM Yi Zhang <[email protected]> wrote: > > > > > > > > > > Hi > > > > > > > > > > With the latest Linux tree, my DCPMM server boot failed with the > > > > > bellow panic log, pls help check it, let me know if you need any test > > > > > for it. > > > > > > > > So v5.12 is ok but v5.12+ is not? > > > > > > > > Might you be able to bisect? > > > > > > Hi Dan > > > This issue was introduced with this patch, let me know if you need more > > > info. > > > > > > commit cf16b05c607bd716a0a5726dc8d577a89fdc1777 > > > Author: Bob Moore <[email protected]> > > > Date: Tue Apr 6 14:30:15 2021 -0700 > > > > > > ACPICA: ACPI 6.4: NFIT: add Location Cookie field > > > > > > Also, update struct size to reflect these changes in nfit core driver. > > > > > > ACPICA commit af60199a9a1de9e6844929fd4cc22334522ed195 > > > > > > Link: https://github.com/acpica/acpica/commit/af60199a > > > Cc: Dan Williams <[email protected]> > > > Signed-off-by: Bob Moore <[email protected]> > > > Signed-off-by: Erik Kaneda <[email protected]> > > > Signed-off-by: Rafael J. Wysocki <[email protected]> > > > > > > > It's likely that this change forced the nfit driver's code to parse the > > ACPI table so that it assumes that the location cookie field is always > > enabled and the NFIT was parsed incorrectly. Does the NFIT table on this > > platform contain a valid cookie field? > > > > This was my fault. When I saw the size change fly by, I should have > remembered to go update all the places that do "sizeof(struct > acpi_nfit_system_address)". > > Yi Zhang, can you give the attached patch a try:
Hi Dan My DCPMM server boots up now with this patch, feel free to add: Tested-by: Yi Zhang <[email protected]> _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
