Hi,
On Tue, 24 Jun 2008 18:55:26 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote:
> +static inline void __init omap2evm_init_smc911x(void)
> +{
> + int gpio = OMAP2EVM_ETHR_GPIO_IRQ;
> + int ret;
> +
> + ret = gpio_request(gpio, "smc911x IRQ");
> + if (ret >= 0)
> + gpio_direction_input(gpio);
> + else
> + printk(KERN_ERR "Failed to request GPIO for smc911x
this would look better like this:
if (ret < 0) {
printk(KERN_ERR "Failed to request GPIO %d for smc911x IRQ\n",
gpio);
return;
}
gpio_direction_input(gpio);
besides this, it looks fine :-)
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
