Hi Tony, Jarkko, > > Let's rather get rid of the direct mcbsp register tinkering from > > drivers and use following instead: > > > Workaround for omap_mcbsp3_aic23_clock_init not adding new McBSP API > would be to put those registers into "struct omap_mcbsp_reg_cfg" and > call omap_mcbsp_config.
You know I am curious which omap board this function was added for? Going back and reviewing the OMAP5912 OSK schematics the 12MHz clock for the aic23 is provided from the OMAP5912 MCLK and not the McBSP3. So my feeling is that short term this should definitely be moved from the aic23 driver to a board specific file because I am not sure that this is even necessary for OMAP5912. > > And, really the best solution would be to add support to > > sound/soc/omap/ for various codecs rather than try to keep > > the old drivers working. > > > I propose this as well. Luckily it seems that someone is already > developing ASoC driver for TLV320AIC23B. Then native ALSA SoC support > for OSK require only to develope new machine driver in sound/soc/omap/. Sounds good. Forgive me here as I am not familiar with how the organisation is planned. So my original patches were to just resolve compiler issues...quick but dirty. However, this seems much nicer long-term. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
