* Felipe Balbi <[EMAIL PROTECTED]> [080820 13:17]:
> On Wed, Aug 20, 2008 at 12:51:51PM +0300, Hiroshi DOYU wrote:
> > +int vclk_enable(struct clk *clk)
> > +{
> > +   int i;
> > +   struct vclk *vc = container_of(clk, struct vclk, clk);
> > +
> > +   for (i = 0; i < vc->n_childs; i++)
> > +           clk_enable(vc->childs[i]);
> 
> missing an error check for clk_enable()

And disable all virtual clocks if any of them fail?
Looks good other than that.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to