----- Original Message -----
From: "Tony Lindgren" <[EMAIL PROTECTED]>
To: "Woodruff, Richard" <[EMAIL PROTECTED]>
Cc: "Jarkko Lavinen" <[EMAIL PROTECTED]>; <[email protected]>
Sent: Thursday, September 11, 2008 5:35 AM
Subject: Re: HSMMC pending fixes
>* Woodruff, Richard <[EMAIL PROTECTED]> [080818 14:09]:
>> Hi,
>>
>> > [EMAIL PROTECTED] On Behalf Of Jarkko Lavinen
>>
>>
>> > 2: Disable smartidle mode while suspending (workaround)
>>
>> This was the work around we had in internal trees for a long time.
>>
>> However Madhu C. recently updated this based on an internal investigation.
>> It is required to reset the command pin to clear the system for sleep. This
>> allows retention to work.
>>
>> The non-idle work around when profiled showed it was taking a huge amount of
>> time for the clock re-enable to work. This actually would noticeably reduce
>> MMC throughput when doing aggressive clock cutting in the driver and
>> increase power usage.
>>
>> + } else {
>> + OMAP_HSMMC_WRITE(host->base, SYSCTL,
>> + OMAP_HSMMC_READ(host->base, SYSCTL) | SRD);
>> + while (OMAP_HSMMC_READ(host->base, SYSCTL) & SRD) ;
>>
>> If you use a really long time out then perhaps it doesn't matter. But if
>> you try and be aggressive it will hurt you.
>
> Pushing all except the workaround. Madhu, can you please send a patch
> for what Richard is describing?
Tony, I have already posted the above fix to L-o. I see that it is merged as
well. With this fix, I guess there is no need to disable smart idle mode while
suspending. Am I missing any other thing here?
Regards,
Madhu
>
> Thanks,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
