> Trivial cleanup patch. Do not return values in void
> functions
> 

I had sent that fix for the same, though not merged in yet. :)

==Cut here

From: Jagadeesh Bhaskar Pakaravoor <[EMAIL PROTECTED]>

Return type of gpmc_init() function is void. Also, the error values
returned by the function is not used by the caller. Hence it should
not be returning any value.

Signed-off-by: Anand Gadiyar <[EMAIL PROTECTED]>
Signed-off-by: Jagadeesh Bhaskar Pakaravoor <[EMAIL PROTECTED]>
--
Index: linux-omap-git/arch/arm/mach-omap2/gpmc.c
===================================================================
--- linux-omap-git.orig/arch/arm/mach-omap2/gpmc.c      2008-09-25 
17:30:24.000000000 +0530
+++ linux-omap-git/arch/arm/mach-omap2/gpmc.c   2008-09-29 18:26:40.845433948 
+0530
@@ -427,16 +427,13 @@ void __init gpmc_init(void)
        }
 
        gpmc_l3_clk = clk_get(NULL, ck);
-       if (IS_ERR(gpmc_l3_clk)) {
+       if (IS_ERR(gpmc_l3_clk))
                printk(KERN_ERR "Could not get GPMC clock %s\n", ck);
-               return -ENODEV;
-       }
 
        gpmc_base = ioremap(l, SZ_4K);
        if (!gpmc_base) {
                clk_put(gpmc_l3_clk);
                printk(KERN_ERR "Could not get GPMC register memory\n");
-               return -ENOMEM;
        }
 
        BUG_ON(IS_ERR(gpmc_l3_clk));
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to