Hi,

Just an initial comment to this patch, this is somewhat experimental and
I think we should agree what registers will actually be saved here and
what should be left for drivers. CM_CLKSEL4 is for DPLL5 which is used
by USB. Two of the CLKEN registers are more interesting.

-Tero

>-----Original Message-----
>From: [EMAIL PROTECTED] 
>[mailto:[EMAIL PROTECTED] On Behalf Of ext Tero Kristo
>Sent: 19 November, 2008 11:32
>To: [email protected]
>Subject: [PATCH] PM: Added three PLL registers to the PRCM context save
>
>These registers are now also saved:
>       CM_CLKSEL4
>       CM_CLKEN
>       CM_CLKEN2
>
>Signed-off-by: Tero Kristo <[EMAIL PROTECTED]>
>---
> arch/arm/mach-omap2/prcm.c |   14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/prcm.c 
>b/arch/arm/mach-omap2/prcm.c index d5a1e4b..c64b668 100644
>--- a/arch/arm/mach-omap2/prcm.c
>+++ b/arch/arm/mach-omap2/prcm.c
>@@ -46,7 +46,10 @@ struct omap3_prcm_regs {
>       u32 emu_cm_clksel;
>       u32 emu_cm_clkstctrl;
>       u32 pll_cm_autoidle2;
>+      u32 pll_cm_clksel4;
>       u32 pll_cm_clksel5;
>+      u32 pll_cm_clken;
>+      u32 pll_cm_clken2;
>       u32 cm_polctrl;
>       u32 iva2_cm_fclken;
>       u32 core_cm_fclken1;
>@@ -233,8 +236,14 @@ void omap3_prcm_save_context(void)
>                        cm_read_mod_reg(OMAP3430_EMU_MOD, 
>CM_CLKSTCTRL);
>       prcm_context.pll_cm_autoidle2 =
>                        cm_read_mod_reg(PLL_MOD, CM_AUTOIDLE2);
>+      prcm_context.pll_cm_clksel4 =
>+                      cm_read_mod_reg(PLL_MOD, 
>OMAP3430ES2_CM_CLKSEL4);
>       prcm_context.pll_cm_clksel5 =
>                        cm_read_mod_reg(PLL_MOD, 
>OMAP3430ES2_CM_CLKSEL5);
>+      prcm_context.pll_cm_clken =
>+                      cm_read_mod_reg(PLL_MOD, CM_CLKEN);
>+      prcm_context.pll_cm_clken2 =
>+                      cm_read_mod_reg(PLL_MOD, OMAP3430ES2_CM_CLKEN2);
>       prcm_context.cm_polctrl = __raw_readl(OMAP3430_CM_POLCTRL);
>       prcm_context.iva2_cm_fclken =
>                        cm_read_mod_reg(OMAP3430_IVA2_MOD, 
>CM_FCLKEN); @@ -380,8 +389,13 @@ void omap3_prcm_restore_context(void)
>                                        CM_CLKSTCTRL);
>       cm_write_mod_reg(prcm_context.pll_cm_autoidle2, PLL_MOD,
>                                        CM_AUTOIDLE2);
>+      cm_write_mod_reg(prcm_context.pll_cm_clksel4, PLL_MOD,
>+                                      OMAP3430ES2_CM_CLKSEL4);
>       cm_write_mod_reg(prcm_context.pll_cm_clksel5, PLL_MOD,
>                                        OMAP3430ES2_CM_CLKSEL5);
>+      cm_write_mod_reg(prcm_context.pll_cm_clken, PLL_MOD, CM_CLKEN);
>+      cm_write_mod_reg(prcm_context.pll_cm_clken2, PLL_MOD,
>+                                      OMAP3430ES2_CM_CLKEN2);
>       __raw_writel(prcm_context.cm_polctrl, OMAP3430_CM_POLCTRL);
>       cm_write_mod_reg(prcm_context.iva2_cm_fclken, OMAP3430_IVA2_MOD,
>                                        CM_FCLKEN);
>--
>1.5.4.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe 
>linux-omap" in the body of a message to 
>[EMAIL PROTECTED] More majordomo info at  
>http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to