On Friday 21 November 2008, [EMAIL PROTECTED] wrote:
> +static const struct i2c_device_id tvp514x_id[] = {
> +       {MODULE_NAME, 0},
> +       {},
> +};

Don't do that.  Instead:

        { "tvp5146", 0 },
        { "tvp5147", 0 },

and so on.  Maybe pass a flag there to help determine which
chip reset/init message sequence to use.  (Which, hmm, I did
not see in this code, although the data sheets are clear
that the '46 needs 12 writes and the '47 needs 18 ...)  Or
tell if the extra '46 registers are available, etc.


> +late_initcall(tvp514x_init);

Why is this "late" instead of normal module_init()?
It's unusual for I2C...

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to