Hi David,
On Thu, 23 Oct 2008, David Brownell wrote:
> On Saturday 18 October 2008, Paul Walmsley wrote:
> > --- a/arch/arm/mach-omap2/omapdev-common.h
> > +++ b/arch/arm/mach-omap2/omapdev-common.h
> > @@ -21,6 +21,87 @@
> > #include "omapdev3xxx.h"
> >
> > static struct omapdev *omapdevs[] = {
> > +
> > +#ifdef CONFIG_ARCH_OMAP2420
> > + &mpu_242x_omapdev,
> > + &iva_242x_omapdev,
> > + &gfx_242x_omapdev,
> > ...
>
> Urgh, this is unpleasant style: declaration of a large
> static data structure in a header file.
>
> Cleaner: just have some omap2420-specific C file declare
> the struct, and hand it off to whatever code uses it.
Not sure I understand what you'd like to see. Could you send a short code
snippet as an example? One caveat is that whatever we go with here will
need to work for a multi-OMAP kernel.
- Paul
