* Aguirre Rodriguez, Sergio Alberto <[email protected]> [081215 09:02]:
> > From: Tony Lindgren [mailto:[email protected]]
> > * Aguirre Rodriguez, Sergio Alberto <[email protected]> [081211 12:44]:
> > > + case V4L2_POWER_OFF:
> > > +         /* Power Down Sequence */
> > > +#ifdef CONFIG_TWL4030_CORE
> > > +         twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
> > > +                         VAUX_DEV_GRP_NONE, TWL4030_VAUX2_DEV_GRP);
> > > +#else
> > > +#error "no power companion board defined!"
> > > +#endif
> > 
> > These checks look unecessary. How about just handle it with Kconfig?
> > 
> [Aguirre, Sergio] But how? Don't you think that if I do that, I'll tighten 
> the sensor driver to this board only?
> 

See what we've done with arch/arm/mach-omap2/mmc-twl4030.c for example
in linux-omap tree. The twl and mmc patches are on their way to the mainline
kernel too hopfully this merge window.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to