> -----Original Message-----
> From: [email protected] 
> [mailto:[email protected]] On Behalf Of Premi, Sanjeev
> Sent: Friday, January 09, 2009 10:29 PM
> To: Aguirre Rodriguez, Sergio Alberto; [email protected]
> Subject: RE: [PATCH 0/3] Add support for OMAP35x processors
> 
> <snip>
> 
> > > +config ARCH_OMAP35XX
> > > + bool "OMAP35x Family"
> > > + select ARCH_OMAP3
> > > + select ARCH_OMAP34XX
> > > + select ARCH_OMAP3430
> > > + select OMAP3430_ES2
> > 
> > AFAIK the above select (OMAP3430_ES2) doesn't exist. 
> > omap_rev() is used in drivers to check instead.
> 
> [sp] Wasn't aware; will remove it.

Done.

> 
> > Question to all,
> > 
> > Why don't making above options as choice.. endchoice. Or is 
> there any 
> > case that multiple boards are compiled at once?
> 
> [sp] It is a quick change; will wait for a day - just in case 
> there is a different opinion.

Done for OMAP3 boards only. There were few cases of circular dependency in H4 
boards; and an additional "default" value set for MACH_OMAP2_TUSB6010 (line 
109).

Though I was able to take care of circular dependency by moving the config 
items out of choice .. endchoice block, wasn't sure of impact if I removed the 
default value.

I will be sending the updated patches shortly. Hope we can use this patch-set 
as base; and people closely associated with other boards can make necessary 
changes to move other boards into the choice..endchoice block.

~sanjeev 

> 
> > Regards,
> > Sergio
> > 
> 
> Best regards,
> Sanjeev--
> To unsubscribe from this list: send the line "unsubscribe 
> linux-omap" in the body of a message to 
> [email protected] More majordomo info at  
> http://vger.kernel.org/majordomo-info.html
> 
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to