On Mon, Jan 19, 2009 at 12:36:12PM +0200, Hiroshi DOYU wrote: > Hi Russell, Thank you for your review. > > From: "ext Russell King - ARM Linux" <[email protected]> > Subject: Re: [PATCH 07/10] omap mailbox: add save_/restore_ctx() for PM > Date: Sat, 17 Jan 2009 17:20:37 +0000 > > > On Sat, Jan 17, 2009 at 05:10:44PM +0000, Russell King - ARM Linux wrote: > > > On Fri, Jan 16, 2009 at 10:27:37AM +0200, Hiroshi DOYU wrote: > > > > diff --git a/arch/arm/mach-omap2/mailbox.c > > > > b/arch/arm/mach-omap2/mailbox.c > > > > index a877305..544dde9 100644 > > > > --- a/arch/arm/mach-omap2/mailbox.c > > > > +++ b/arch/arm/mach-omap2/mailbox.c > > [...] > > > Hmm, don't forget 'i' is an offset not an index, so... > > > > £define MBOX_NR_REGS (MBOX_REG_SIZE / sizeof(u32)) > > > > for (i = 0; i < MBOX_NR_REGS; i++) { > > p->ctx[i] = mbox_read_reg(i * sizeof(u32)); > > The updated one is attached.
... which looks much better, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
