Hi Russell,

From: "ext Russell King - ARM Linux" <[email protected]>
Subject: Re: [PATCH 6/6] omap2 iommu: entries for Kconfig and Makefile
Date: Sat, 17 Jan 2009 16:59:20 +0000

> On Fri, Jan 16, 2009 at 10:37:35AM +0200, Hiroshi DOYU wrote:
> > Signed-off-by: Hiroshi DOYU <[email protected]>
> > ---
> > 
> >  arch/arm/mach-omap2/Makefile |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> > index bbd12bc..443e71f 100644
> > --- a/arch/arm/mach-omap2/Makefile
> > +++ b/arch/arm/mach-omap2/Makefile
> > @@ -24,6 +24,11 @@ endif
> >  obj-$(CONFIG_ARCH_OMAP2)           += clock24xx.o
> >  obj-$(CONFIG_ARCH_OMAP3)           += clock34xx.o
> >  
> > +obj-$(CONFIG_OMAP_IOMMU)           += iommu2.o
> > +ifeq ($(CONFIG_ARCH_OMAP3),y)
> > +obj-$(CONFIG_OMAP_IOMMU)           += omap3-iommu.o
> > +endif
> > +
> 
> I can see this expanding still further... so what about nipping it now
> before it gets out of hand:
> 
> iommu-y                                       += iommu2.o
> iommu-$(CONFIG_ARCH_OMAP3)            += omap3-iommu.o
> 
> obj-$(CONFIG_OMAP_IOMMU)              += $(iommu-y)

Much simpler. Thanks. The updated one is attached.
>From 80c17b5d26e89a3c5a65b2dfac02eeaf6426404b Mon Sep 17 00:00:00 2001
From: Hiroshi DOYU <[email protected]>
Date: Mon, 19 Jan 2009 13:01:01 +0200
Subject: [PATCH 6/6] omap2 iommu: entries for Kconfig and Makefile

Signed-off-by: Hiroshi DOYU <[email protected]>
---
 arch/arm/mach-omap2/Makefile |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index bbd12bc..4f6123d 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -24,6 +24,11 @@ endif
 obj-$(CONFIG_ARCH_OMAP2)               += clock24xx.o
 obj-$(CONFIG_ARCH_OMAP3)               += clock34xx.o
 
+iommu-y                                        += iommu2.o
+iommu-$(CONFIG_ARCH_OMAP3)             += omap3-iommu.o
+
+obj-$(CONFIG_OMAP_IOMMU)               += $(iommu-y)
+
 # Specific board support
 obj-$(CONFIG_MACH_OMAP_GENERIC)                += board-generic.o
 obj-$(CONFIG_MACH_OMAP_H4)             += board-h4.o
-- 
1.6.1.rc4

Reply via email to