ext Hemanth V <[email protected]> writes: > ----- Original Message ----- > From: "Kevin Hilman" <[email protected]> > To: "Hemanth V" <[email protected]> > Cc: "Aaro Koskinen" <[email protected]>; <[email protected]> > Sent: Thursday, February 05, 2009 7:59 PM > Subject: Re: [PATCH PM 1/2] OMAP McSPI: Fix context save/restore > > >> "Hemanth V" <[email protected]> writes: >> >>>> Fix context save/restore to work with chip select. Also update the >>>> shadow >>>> CHCONF0 register on every write and eliminate register reads. >>> >>> I believe the shadow CHCONF register need to have only the default >>> configuration as initialized by omap2_mcspi_setup_transfer(), since other >>> other >>> bits are initialized as and when required by omap2_mcspi_work(). >>> >>> The original problem you saw might be because of not masking >>> OMAP2_MCSPI_CHCONF_TRM_MASK and OMAP2_MCSPI_CHCONF_FORCE bits while >>> storing to >>> shadow register. >> >> Hemanth, >> >> Can you address this problem and post a single patch with the full >> save/restore. >> >> I have reverted the original patch in the pm branch and would like >> to see a single patch including the fixes from Jouni and Aaro. > > Kevin, > > Both fixes cannot be taken since they are conflicting, I would like > to go with Jouni's fix.
Bad thing in that one is that it doesn't work:) Kevin, to my understanding patches from Aaro Koskinen are working. If they are ok to you, please push them. So the patches are: [PATCH PM 0/2] OMAP McSPI: Fixes to save/restore [PATCH PM 1/2] OMAP McSPI: Fix context save/restore [PATCH PM 2/2] OMAP McSPI: spin_unlock_irq() missing and the sender is Koskinen Aaro. Those patches are working alone. -- Jouni Högander -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
