> >> Looks fine to me, but I wonder if you know why the regulator is > >> turned on (DEV_GRP) and then the voltage is selected (DEDICATED). > > > > History, I'd guess. I seem to remember some sequencing > > constraint, but couldn't find it when last I sought it > > out in the reference manual. > > What about section 5.5.1 item 6?
That's an example. I'm thinking the constraint had to do with one or more of the USB regulators. It just doesn't make sense to have a *general* rule that the resource needs to be enabled before tweaking. Maybe it was an erratum or something. > >> Wouldn't it make more sense the other way around? > > > > I had the same thought. Eventually I'd like this code > > to mostly wither away ... using the regulator framework > > for the hsmmc driver will eliminate most of the remaining > > bits of twl4030-specific code. So I'd just leave it be > > for the moment. > > > > > >> Doesn't the new regulator framework do it that way? > > > > No; setting voltage and enabling are distinct operations. > > Perhaps, but there are features like regulator constraints, > or the Virtual regulator that do set the voltage and then > enable. Right, and I have most certainly configured regulators with regulator_init_data.constraints.apply_uV so that the VSEL gets set to a sane value as Linux sets up, since u-boot wasn't touching it. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
