Hi. Thank you for your reply. I'm looking forward to see Sakari's new patch :) Cheers,
Nate On Tue, Mar 3, 2009 at 4:37 AM, Aguirre Rodriguez, Sergio Alberto <[email protected]> wrote: > Hi Nate, > >> -----Original Message----- >> From: DongSoo(Nathaniel) Kim [mailto:[email protected]] >> Sent: Monday, March 02, 2009 2:10 AM >> To: Aguirre Rodriguez, Sergio Alberto >> Cc: [email protected]; [email protected]; Nagalla, >> Hari; Sakari Ailus; Tuukka.O Toivonen; [email protected] >> Subject: Re: [REVIEW PATCH 09/14] OMAP: CAM: Add ISP Core >> >> Hello, >> >> reviewing ISP driver, I found that we've got no querymenu support in >> ISP and also omap3 camera interface driver. > > Sakari is about to repost our latest progress on this driver, and exactly one > of the changes we did is added this support for querymenu on both camera and > ISP drivers. > >> >> +/** >> + * struct vcontrol - Video control structure. >> + * @qc: V4L2 Query control structure. >> + * @current_value: Current value of the control. >> + */ >> +static struct vcontrol { >> + struct v4l2_queryctrl qc; >> + int current_value; >> +} video_control[] = { >> >> <snip> >> >> + { >> + { >> + .id = V4L2_CID_PRIVATE_ISP_COLOR_FX, >> + .type = V4L2_CTRL_TYPE_INTEGER, >> + .name = "Color Effects", >> + .minimum = PREV_DEFAULT_COLOR, >> + .maximum = PREV_BW_COLOR, >> + .step = 1, >> + .default_value = PREV_DEFAULT_COLOR, >> + }, >> + .current_value = PREV_DEFAULT_COLOR, >> + } >> +}; >> >> I think we should make it menu type for this color FX control. >> If that kind of control has no menu information, user has no way to >> figure out what kind of FX supported by device. >> BTW if we make querymenu support in omap3 camera subsystem, we should >> make querymenu support for v4l2 int device also. >> I think I've seen before a patch which intent to use querymenu in v4l2 >> int device, but no patch for omap3 ISP and camera interface. >> Can I make a patch and post on linux-omap, linux-media list? of course >> if you don't mind. >> Or...am I digging wrong way? I mean.. querymenu for omap3 camera subsystem. >> Please let me know :) > > Please hold a bit, as we expect to repost the driver again this week. > > This control is now substituted by V4L2_CID_COLORFX, with seems to be already > accepted for merging into v4l: > > http://osdir.com/ml/linux-media/2009-02/msg00593.html > > Anyways, thanks for your intended help on this. Expect new patches very soon. >> >> Cheers, >> >> Nate >> >> -- >> ======================================================== >> DongSoo(Nathaniel), Kim >> Engineer >> Mobile S/W Platform Lab. >> Telecommunication R&D Centre >> Samsung Electronics CO., LTD. >> e-mail : [email protected] >> [email protected] >> ======================================================== > > -- ======================================================== DongSoo(Nathaniel), Kim Engineer Mobile S/W Platform Lab. S/W centre Telecommunication R&D Centre Samsung Electronics CO., LTD. e-mail : [email protected] [email protected] ======================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
