On Fri, Mar 21, 2014 at 09:57:52PM +0530, Balaji T K wrote: > On Friday 21 March 2014 09:48 PM, Felipe Balbi wrote: > >On Fri, Mar 21, 2014 at 09:47:33PM +0530, Balaji T K wrote: > >>With devm_request_mem_region conversion release_mem_region can be > >>removed in clean up path > >> > >>Signed-off-by: Balaji T K <[email protected]> > >>--- > >> drivers/mmc/host/omap_hsmmc.c | 11 ++--------- > >> 1 files changed, 2 insertions(+), 9 deletions(-) > >> > >>diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > >>index 8e35a6e..9952673 100644 > >>--- a/drivers/mmc/host/omap_hsmmc.c > >>+++ b/drivers/mmc/host/omap_hsmmc.c > >>@@ -1881,7 +1881,8 @@ static int omap_hsmmc_probe(struct platform_device > >>*pdev) > >> if (res == NULL || irq < 0) > >> return -ENXIO; > >> > >>- res = request_mem_region(res->start, resource_size(res), pdev->name); > >>+ res = devm_request_mem_region(&pdev->dev, res->start, > >>+ resource_size(res), pdev->name); > > > >while at that, why don't you switch over to devm_ioremap_resource() > >already ? > > I can't do that because of 0x100 reg_offset on OMAP4+ and am335x+
split the resource into two parts, one is OMAP-specific and the other is the generic SDHCI start. -- balbi
signature.asc
Description: Digital signature
