Hi Roger,
>From: Quadros, Roger
>
[...]
>> +&gpmc {
>> + status = "okay";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&nand_flash_x8>;
>> + ranges = <0 0 0 0x01000000>; /* minimum GPMC partition = 16MB */
>> + nand@0,0 {
>> + reg = <0 0 0x37c>; /* device IO registers */
>
>This register space is used by the parent GPMC node as well as the NAND
>controller. So doing a
>request_and_ioremap() on this space will fail as it is already taken by the
>GPMC driver.
>
>Further, the GPMC register space doesn't map to the GPMC memory map created by
>this Chip select
>but it is mapped to L3_IO space. i.e. (physical address 0x6e00 0000)
>
>We could have split the GPMC register space into GPMC part and NAND part but
>to add to the
>complexity, the register spaces for GPMC vs NAND are interleaved so it can't
>be easily split up.
Sorry I din't get this part.
NAND is one of the devices supported by GPMC controller.
Hardware wise the it's the same engine is used for NAND, NOR and OneNAND
and even other parallel interfaces like Camera, Ethernet, etc..
So how can be NAND and GPMC registers space be splitted ?
I see gpmc.c as generic controller driver, which just does initializations
and registering the device. Then it's upto the individual protocol drivers
to probe the device and attach it to respective sub-system; like;
(a) drivers/mtd/nand/omap2.c for NAND
(b) drivers/mtd/chips/cfi_probe.c for NOR
...
> The way
>the NAND driver is currently written is that it expects the register addresses
>to come via platform data,
>primarily to get around this address interleaving issue.
>
Yes, that is right.
I don't know the historical reasons but that is correct also because,
(1) large set of GPMC register configurations are common across all
types of devices (like NAND, NOR, OneNAND, Ethernet). These
register configurations define the signal timings and physical attributes
of device (like device width, etc).
(2) Individual protocol drivers (a) and (b) only uses a sub-set of registers
for transferring data, much of which is based on type of protocol.
So, large part of GPMC configurations remains static and can be
Shared across all types of devices, hence those are put in gpmc.c
>Apart from the GPMC register space, the NAND controller uses 4 bytes of GPMC
>memory map for I/O,
>and that is something that could be reflected here.
>
>e.g.
> reg = <0 0 4>; /* NAND I/O space */
>
>But still, the start address can't be 0 and has to be assigned when this CS
>region is mapped. It is still
>unclear to me how that can be done.
>
Yes, NAND is not directly mapped. So only 4-bytes of I/O size will do.
But where to map these 4 bytes ? and which 4-bytes to map.
So I have included complete GPMC register space-size.
Also since GPMC has a constrain that every chip-select must have
minimum of 16MB memory. So we specify it via <range> property
to keep GPMC mapping consistent across all NAND, NOR, OneNAND, etc..
If you have any better approach in mind for keeping consistent
memory mapping across different types of devices, then please suggest ..
I'll try to get this done in next set of patches, if not these.
Or
May be you can take over as part of GPMC transition.
>cheers,
>-roger
>
with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
