* Balaji T K <[email protected]> [140519 04:54]: > On Saturday 17 May 2014 03:11 AM, Tony Lindgren wrote: > >>- > >>-#if defined(CONFIG_DMA_OMAP) || defined(CONFIG_DMA_OMAP_MODULE) > >>-bool omap_dma_filter_fn(struct dma_chan *, void *); > >>-#else > >>-static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) > >>-{ > >>- return false; > >>-} > >>-#endif > >>+#include <linux/omap-dmaengine.h> > > > >Can't the drivers needing this include it directly? > > > > Yes, I have converted omap_hsmmc as part of this patch. > Due to lack of bandwidth, I haven't touched upon all other drivers that > include > omap-dma.h. Once that is done in other subsystem after this patch gets merged, > this include can then be removed from omap-dma.h
OK > >Also, has this been tested with make randconfig? Changes like > >this can easily cause problems elsewhere.. > > May be I am missing something, Can you please elaborate ? You're touching a header included in many places, so you need to make sure you're not accidentally breaking anything. There's an option that allows you to specify some selected options like CONFIG_ARCH_OMAP2PLUS=y with KCONFIG_ALLCONFIG and then run make randconfig. This should expose quite fast if there are some issues for the other drivers. Also, have you compile tested this with omap1_defconfig? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
