+linux-omap.
On 06/15/2014 08:44 PM, Axel Lin wrote:
Might be nice to have a commit message here.
> Signed-off-by: Axel Lin <axel....@ingics.com>
> ---
> drivers/regulator/twl-regulator.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/regulator/twl-regulator.c
> b/drivers/regulator/twl-regulator.c
> index fed28ab..0b4f866 100644
> --- a/drivers/regulator/twl-regulator.c
> +++ b/drivers/regulator/twl-regulator.c
> @@ -1128,7 +1128,7 @@ static int twlreg_probe(struct platform_device *pdev)
> if (!initdata)
> return -EINVAL;
>
> - info = kmemdup(template, sizeof(*info), GFP_KERNEL);
> + info = devm_kmemdup(&pdev->dev, template, sizeof(*info), GFP_KERNEL);
> if (!info)
> return -ENOMEM;
>
> @@ -1192,7 +1192,6 @@ static int twlreg_probe(struct platform_device *pdev)
> if (IS_ERR(rdev)) {
> dev_err(&pdev->dev, "can't register %s, %ld\n",
> info->desc.name, PTR_ERR(rdev));
> - kfree(info);
> return PTR_ERR(rdev);
> }
> platform_set_drvdata(pdev, rdev);
> @@ -1212,20 +1211,10 @@ static int twlreg_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int twlreg_remove(struct platform_device *pdev)
> -{
> - struct regulator_dev *rdev = platform_get_drvdata(pdev);
> - struct twlreg_info *info = rdev->reg_data;
> -
> - kfree(info);
> - return 0;
> -}
> -
> MODULE_ALIAS("platform:twl_reg");
>
> static struct platform_driver twlreg_driver = {
> .probe = twlreg_probe,
> - .remove = twlreg_remove,
> /* NOTE: short name, to work around driver model truncation of
> * "twl_regulator.12" (and friends) to "twl_regulator.1".
> */
>
otherwise, looks good to me.
Reviewed-by: Nishanth Menon <n...@ti.com>
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
