Em Tue, 9 Sep 2014 15:41:58 +0100 Russell King - ARM Linux <li...@arm.linux.org.uk> escreveu:
> On Tue, Sep 09, 2014 at 11:38:17AM -0300, Mauro Carvalho Chehab wrote: > > We want to be able to COMPILE_TEST the omap1_camera driver. > > It compiles fine, but it fails linkediting: > > > > ERROR: "omap_stop_dma" [drivers/media/platform/soc_camera/omap1_camera.ko] > > undefined! > > ERROR: "omap_start_dma" [drivers/media/platform/soc_camera/omap1_camera.ko] > > undefined! > > ERROR: "omap_dma_link_lch" > > [drivers/media/platform/soc_camera/omap1_camera.ko] undefined! > > ERROR: "omap_set_dma_dest_burst_mode" > > [drivers/media/platform/soc_camera/omap1_camera.ko] undefined! > > ERROR: "omap_set_dma_src_params" > > [drivers/media/platform/soc_camera/omap1_camera.ko] undefined! > > ERROR: "omap_request_dma" > > [drivers/media/platform/soc_camera/omap1_camera.ko] undefined! > > ERROR: "omap_set_dma_transfer_params" > > [drivers/media/platform/soc_camera/omap1_camera.ko] undefined! > > ERROR: "omap_set_dma_dest_params" > > [drivers/media/platform/soc_camera/omap1_camera.ko] undefined! > > ERROR: "omap_free_dma" [drivers/media/platform/soc_camera/omap1_camera.ko] > > undefined! > > > > So, add some stub functions to avoid it. > > The real answer to this is to find someone who still uses it, and convert > it to the DMA engine API. If there's no users, the driver might as well > be killed off. Hmm... it seems that there are still several drivers still relying on the functions declared at: omap-dma.h: $ grep extern include/linux/omap-dma.h |perl -ne 'print "$1\n" if (m/extern\s\S+\s(.*)\(/)' >funcs && git grep -f funcs -l arch/arm/mach-omap1/pm.c arch/arm/mach-omap2/pm24xx.c arch/arm/plat-omap/dma.c drivers/dma/omap-dma.c drivers/media/platform/omap/omap_vout_vrfb.c drivers/media/platform/omap3isp/isphist.c drivers/media/platform/soc_camera/omap1_camera.c drivers/mtd/onenand/omap2.c drivers/usb/gadget/udc/omap_udc.c drivers/usb/musb/tusb6010_omap.c drivers/video/fbdev/omap/omapfb_main.c include/linux/omap-dma.h Perhaps we can remove the header and mark all the above as BROKEN. If nobody fixes, we can strip all of them from the Kernel. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
