Hello Kevin, Ramesh,

On Thu, 12 Feb 2009, Kevin Hilman wrote:

> "Gupta, Ramesh" <[email protected]> writes:
> 
> > This Patch exports symbols clk_notifier_register/unregister
> > function for other kernel modules usage.
> >
> > Signed-off-by: Ramesh Gupta G <[email protected]>
> 
> Thanks, pushed to PM branch.

As an aside, this patch should be reverted.  DSPBridge and other drivers 
needing clock notifiers should pass function pointers to 
clk_notifier_{register,unregister}() in their struct platform_data, rather 
than exporting those symbols.  This will keep the drivers 
platform-agnostic, since system-wide clock notifiers are not yet upstream.

regards,

- Paul

> > ---
> >  arch/arm/plat-omap/clock.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/clock.c b/arch/arm/plat-omap/clock.c
> > index e0940a1..c8d9e96 100644
> > --- a/arch/arm/plat-omap/clock.c
> > +++ b/arch/arm/plat-omap/clock.c
> > @@ -680,6 +680,7 @@ int clk_notifier_register(struct clk *clk, struct 
> > notifier_block *nb)
> >  
> >     return r;
> >  }
> > +EXPORT_SYMBOL(clk_notifier_register);
> >  
> >  /**
> >   * clk_notifier_unregister - remove a clock change notifier
> > @@ -735,6 +736,7 @@ int clk_notifier_unregister(struct clk *clk, struct 
> > notifier_block *nb)
> >  
> >     return r;
> >  }
> > +EXPORT_SYMBOL(clk_notifier_unregister);
> >  
> >  
> >  
> > -- 
> > 1.5.3.2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to [email protected]
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to