* Paul Walmsley <[email protected]> [090423 01:35]: > Hello Russell, > > On Thu, 23 Apr 2009, Russell King - ARM Linux wrote: > > > On Wed, Apr 22, 2009 at 08:01:29PM -0600, Paul Walmsley wrote: > > > The patch also renames clk_init_one() to clk_preinit() to > > > distinguish its function from clk_init() and the individual struct clk > > > init functions. > > > > That's rather unnecessary. 'clk_init_one' is already unique. In the > > long run, it's clk_init that needs to go. > > Even if clk_init() were to disappear, the struct clk .init function > pointer would still be present. clk->init() performs a very different > kind of initialization than clk_init_one().
I'm OK doing the rename in this fix. The original naming can cause confusion while reading the code. Tony > > > Incorporates review comments from Russell King > > > <[email protected]>. > > > > Please don't add this email address to git commit comments. Thanks. > > Updated in the git branch to rmk+kernel. > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
