On Thu, Dec 24, 2015 at 07:12:53PM +0100, Paul Kocialkowski wrote: > Le mercredi 23 décembre 2015 à 11:56 +0000, Mark Brown a écrit :
> > This isn't really adding support for the enable GPIO as the changelog > > suggests, it's requesting but not managing the GPIO. Since there is > > core support for manging enable GPIOs this seems especially silly, > > please tell the core about the GPIO and then it will work at runtime > > too. > It looks like the core bindings for GPIO can only be used instead of the > rdev->desc->ops->enable callback, not jointly, which doesn't fit my use > case, where both the GPIO and register write have to be used to enable > regulators. > I think it would be worth making it possible to use both in core, since > that situation is probably shared with other regulators. I suggest the > following diff (that would be split into a separate patch in v2 of this > series): No, that's broken - the whole point with using a GPIO for enable control on a lot of devices is that it is much faster than doing a register write. What I would expect to happen in this case is that when initialsing the GPIO we set the register to enabled and then only manage the GPIO at runtime.
Description: PGP signature