* Russell King - ARM Linux <li...@arm.linux.org.uk> [160104 06:43]: > On Mon, Jan 04, 2016 at 03:27:57PM +0200, Tero Kristo wrote: > > On 01/04/2016 12:21 PM, Geert Uytterhoeven wrote: > > >FWIW, there are small loops with just a cpu_relax() in various clock > > >drivers > > >under drivers/clk/shmobile/. > > > > Just did a quick profiling round, and the clk_enable/disable delay loops > > take anything from 0...1500ns, most typically consuming some 400-600ns. So, > > based on this, dropping the udelay and adding cpu_relax instead looks like a > > good change. I just verified that changing the udelay to cpu_relax works > > fine also, I just need to change the bail-out period to be something sane. > > Was that profiling done with lockdep/lock debugging enabled or disabled?
And also the thing to check from the hw folks is what all do these clkctrl bits really control. If they group together the OCP clock and an extra functional clock for some devices the delays could be larger. In general, I think we need to get rid of pm_runtime_irq_safe usage to allow clocks to sleep properly. The other option is to allow toggling pm_runtime_irq_safe but that probably gets super messy. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html