Hi, On Tue, May 12, 2009 at 12:41 AM, Dmitry Torokhov <[email protected]> wrote: > On Mon, May 11, 2009 at 08:38:09AM -0700, Dmitry Torokhov wrote: >> Hi, >> On Mon, May 11, 2009 at 08:44:00PM +0900, Kwangwoo Lee wrote: >> > From d5de0d22109de7564f9bf1df688acbe6b18f41db Mon Sep 17 00:00:00 2001 >> > From: Kwangwoo Lee <[email protected]> >> > Date: Mon, 11 May 2009 20:05:50 +0900 >> > Subject: [PATCH 2/2] Input: tsc2007: do I2C transfers in non-interrupt >> > context. >> > >> > This patch enhances pointer movements much smoother. >> > The original patch is written by Thierry. >> > >> > --- a/drivers/input/touchscreen/tsc2007.c >> > +++ b/drivers/input/touchscreen/tsc2007.c >> > @@ -70,6 +70,7 @@ struct ts_event { >> > struct tsc2007 { >> > struct input_dev *input; >> > char phys[32]; >> > + struct work_struct work; >> >> Every time I see a work_struct in a driver and don't see >> cancel_work_sync() anywhere I know there are issues... >>
Thanks for your comment. I also missed that thing, sorry. > Also, why do we need to chain irq->timer->work now? Surely we can bypass > the timer if we have to read in process context. It's good point. I'll check again. Thanks. -- Kwangwoo Lee <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
