Tony

>-----Original Message-----
>From: [email protected] 
>[mailto:[email protected]] On Behalf Of
>Pandita, Vikram
>Sent: Tuesday, May 19, 2009 7:01 PM
>To: Tony Lindgren
>Cc: Christensen, Mikkel; [email protected]
>Subject: RE: [PATCH v3 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board
>
>
>
<snip>
>>
>>Well you still cannot have it as a late_initcall(), you should just call the
>>function from board-zoom2.c. Otherwise it will run for all the boards.

Way not execute the debug board function for other boards could be to put it 
under 
#ifdef CONFIG_MACH_OMAP_ZOOM2 

static int __init omap_zoom2_debugboard_init(void)
{
#ifdef CONFIG_MACH_OMAP_ZOOM2
        if (!omap_zoom2_debugboard_detect())
                return 0;

        zoom2_init_smsc911x();
        zoom2_init_quaduart();
        return platform_add_devices(zoom2_devices, ARRAY_SIZE(zoom2_devices));
#endif
}
late_initcall(omap_zoom2_debugboard_init);


The registration order of the UARTS with 8250 driver is all the reason we have 
to do this _initcall()


>
>The problem is that serial.c: platform_device_register() for UART1/2/3 happens 
>as arch_init().
>
>We want that Quard/Dbg-board Uart console to appear as UART4(ttyS3) and so the
>platform_device_register() has to happen after the arch_init() call from 
>serial.c
>
>If we put the dbg-board init in .init_machine   = omap_zoom2_init() function, 
>then this gets called
>first before the serial.c:arch_init() and assigns ttyS0(UART0) to the debug 
>board uart.
>
>This is not what we want to do.
>
>
>>
>>Regards,
>>
>>Tony
>>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to [email protected]
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to