On Thu, May 28, 2009 at 11:20:48AM -0700, Tony Lindgren wrote: > * Andrew de Quincey <[email protected]> [090525 09:41]: > > Quoting Andrew de Quincey <[email protected]>: > > > >> Quoting Russell King - ARM Linux <[email protected]>: > >> > >>> On Tue, May 19, 2009 at 04:37:32PM -0700, Tony Lindgren wrote: > >>>> Make 770 LCD work by passing the clock from platform data. > >>>> Also remove the old unused functions. > >>> > >>> I don't like this - because its passing struct clk's through platform > >>> data. That's not how things are supposed to work. > >>> > >>> The way PXA solves this problem is to have clock aliases - see > >>> clk_add_alias(). > >> > >> Interesting idea - I now have a prototype patch implementing this, > >> which I'll send when I get home (otherwise it would be an "it > >> compiles" "test" :) > >> > >> There isn't a common definition of clk_add_alias() though - that > >> symbol is defined in arch/arm/mach-pxa/clock.c, so I had to copy it > >> into arch/arm/plat-omap/clock.c > > > > Attached is a patch implementing this method. I don't like the > > duplication of the clk_alias code, but I imagine that could be resolved > > if this method was chosen.... > > Andrew, can you please reply with your Signed-off-by?
Actually, I'm very tempted to suggest that clk_add_alias() should go into arch/arm/common/clkdev.c if we're going to have more people use it. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
