From: "Doyu Hiroshi (Nokia-D/Helsinki)" <[email protected]> Subject: [PATCH 1/1] omap mailbox: platform_get_irq() error ignored Date: Mon, 15 Jun 2009 11:25:33 +0200
> From: ext Roel Kluin <[email protected]> Messed up with our mail server...use the following line instead... From: Roel Kluin <[email protected]> > > platform_get_irq may return -ENXIO. but struct omap_mbox mbox_dsp_info.irq > is unsigned, so the error was not noticed. > > Signed-off-by: Roel Kluin <[email protected]> > Signed-off-by: Hiroshi DOYU <[email protected]> > --- > arch/arm/mach-omap2/mailbox.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c > index fd5b8a5..6f71f37 100644 > --- a/arch/arm/mach-omap2/mailbox.c > +++ b/arch/arm/mach-omap2/mailbox.c > @@ -282,12 +282,12 @@ static int __devinit omap2_mbox_probe(struct > platform_device *pdev) > return -ENOMEM; > > /* DSP or IVA2 IRQ */ > - mbox_dsp_info.irq = platform_get_irq(pdev, 0); > - if (mbox_dsp_info.irq < 0) { > + ret = platform_get_irq(pdev, 0); > + if (ret < 0) { > dev_err(&pdev->dev, "invalid irq resource\n"); > - ret = -ENODEV; > goto err_dsp; > } > + mbox_dsp_info.irq = ret; > > ret = omap_mbox_register(&pdev->dev, &mbox_dsp_info); > if (ret) > -- > 1.6.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
