Hi Paul,

> > +                   u8 stat2 = 0;
> > +                   stat2 = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
> > +                   if (stat2 & OMAP_I2C_STAT_BB)
> > +                           return IRQ_HANDLED;
> 
> Why use stat2? Why not just test stat again?

Stat is read at the beginning of the ISR, what if BB bit gets cleared/set a 
while later, not along with RDR, as a corner case?

If we keep it this way, re-reading the register; what could be the potential 
problem?

Thanks!
-Jagadeesh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to