Paul, > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Paul Walmsley > Sent: Wednesday, July 08, 2009 12:53 AM > To: Syed, Rafiuddin > Cc: [email protected]; > [email protected]; Cousson, Benoit; Shilimkar, > Santosh; Tony Lindgren > Subject: Re: [PATCH 1/4] ARM: OMAP4: sDMA: Update the request lines > > Hello Syed, > > This should use the auto-generated data from Benoit. This will avoid > mistakes like: > > On Tue, 7 Jul 2009, [email protected] wrote: > > > From: Santosh Shilimkar <[email protected]> > > > > This patch updates the platform dma.h with new dma request lines > > for OMAP4 peripherals. Also additional hardware register of OMAP4 > > sDMA module are included. > > > > Signed-off-by: Santosh Shilimkar <[email protected]> > > Signed-off-by: Tony Lindgren <[email protected]> > > --- > > arch/arm/plat-omap/include/mach/dma.h | 88 > +++++++++++++++++++++++++++++++++ > > 1 files changed, 88 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/plat-omap/include/mach/dma.h > b/arch/arm/plat-omap/include/mach/dma.h > > index 8c1eae8..01ea54a 100644 > > --- a/arch/arm/plat-omap/include/mach/dma.h > > +++ b/arch/arm/plat-omap/include/mach/dma.h > > @@ -122,6 +122,11 @@ > > #define OMAP_DMA4_CCFN(n) (0x60 * (n) + 0xc0) > > #define OMAP_DMA4_COLOR(n) (0x60 * (n) + 0xc4) > > > > +/* Additional registers available on OMAP4 */ > > +#define OMAP_DMA4_CDP(n) (0x60 * (n) + 0xd0) > > +#define OMAP_DMA4_CNDP(n) (0x60 * (n) + 0xd4) > > +#define OMAP_DMA4_CCDN(n) (0x60 * (n) + 0xd8) > > + > > /* Dummy defines to keep multi-omap compiles happy */ > > #define OMAP1_DMA_REVISION 0 > > #define OMAP1_DMA_IRQSTATUS_L0 0 > > @@ -311,6 +316,89 @@ > > #define OMAP34XX_DMA_USIM_TX 79 /* S_DMA_78 */ > > #define OMAP34XX_DMA_USIM_RX 80 /* S_DMA_79 */ > > > > +/* DMA request lines for 44xx */ > > +#define OMAP44XX_DMA_DSS_DISPC_REQ 6 /* S_DMA_5 */ > > +#define OMAP44XX_DMA_SYS_REQ2 7 /* S_DMA_6 */ > > +#define OMAP44XX_DMA_ISS_REQ1 9 /* S_DMA_8 */ > > +#define OMAP44XX_DMA_ISS_REQ2 10 /* S_DMA_9 */ > > +#define OMAP44XX_DMA_ISS_EQ3 12 /* S_DMA_11 */ > > ^^^^^^^^^^ > > ... this one. > > Suggest you resend a version that uses that data.
I am sorry but what's mistake you noticed in the patch ? Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
