From: Hiroshi DOYU <hiroshi.d...@nokia.com>
Subject: Re: [PATCH 1/1] DSPBRIDGE: expose DSP_TRACEBUF as kernel config option
Date: Fri, 24 Jul 2009 21:00:05 +0300 (EEST)
> Hi Hari,
>
> From: "ext Kanigeri, Hari" <h-kanige...@ti.com>
> Subject: RE: [PATCH 1/1] DSPBRIDGE: expose DSP_TRACEBUF as kernel config
> option
> Date: Fri, 24 Jul 2009 19:28:47 +0200
>
> > Hi Doyu-san,
> >
> > >
> > > "CONFIG_DSP_TRACEBUF" is introduced as a kernel config option to save
> > > some amount of unused memory and "#ifndef DSP_TRACEBUF_DISABLED" was
> > > not easy to understand.
> > >
> >
> > I think we just use the Bridge DEBUG flag that is used in Bridge instead of
> > introducing a new flag.
>
> It might be better if "CONFIG_DSP_TRACEBUF" had the dependecy on
> "DEBUG/CONFIG_BRIDGE_DEBUG", but it's not unfortunately.
>
> The problem here is that now all TRACEBUF code is always compiled in
> in spite of setting "DEBUG". It doesn't print anything, but just
> wastes some memory.
>
> I'll remove a new Kconfig entry and just add the dependency of
> "CONFIG_DSP_TRACEBUF" on "CONFIG_BRIDGE_DEBUG".
How about the following change?
Modified drivers/dsp/bridge/Kconfig
diff --git a/drivers/dsp/bridge/Kconfig b/drivers/dsp/bridge/Kconfig
index a43b19d..d73b097 100644
--- a/drivers/dsp/bridge/Kconfig
+++ b/drivers/dsp/bridge/Kconfig
@@ -32,12 +32,9 @@ config BRIDGE_MEMPOOL_SIZE
config BRIDGE_DEBUG
bool "DSP Bridge Debug Support"
depends on MPU_BRIDGE
+ select DSP_TRACEBUF
help
Say Y to enable Bridge debugging capabilities
config DSP_TRACEBUF
- bool "DSP Debug Trace Support"
- depends on BRIDGE_DEBUG
- help
- Say Y to enable DSP debugging capabilities. baseimage needs
- to be built with debug option.
+ bool
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
