On Mon, Aug 17, 2009 at 10:46:55AM +0530, Krishnamoorthy, Balaji T wrote: > > -----Original Message----- > > From: Samuel Ortiz [mailto:sa...@linux.intel.com] > > Sent: Monday, August 17, 2009 5:30 AM > > To: Krishnamoorthy, Balaji T > > Cc: linux-omap@vger.kernel.org; t...@atomide.com; > > khil...@deeprootsystems.com; > > davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; > > sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- > > li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; > > m...@felipebalbi.com > > Subject: Re: [RFC][PATCH 0/4] TWL6030 patch series > > > > Hi Balaji, > > > > On Tue, Aug 11, 2009 at 06:30:24PM +0530, Krishnamoorthy, Balaji T wrote: > > > Hi All, > > > > > > Can I have your comments on this so that I can rebase the patch for the > > upcoming merge window. > > > > > I looked at the mfd related files, from patchwork.kernel.org. > > A few comments: > > > > * Besides making it look nicer, is there any other reason to change the > > twl4030-core.c name ? > twl-core.c will have common code. twl4030-irq.c will have code specific for > "TWL4030 family" and twl6030-irq.c will have specific code for TWL6030 > family. Ok, I'm fine with renaming then.
> This is to make code easily readable and it wont be misleading. > > * You should also change drivers/mfd/Kconfig to reflect the more generic twl > > support. > > > Added TWL6030 family to it, > tps659x0 can be added if needed. It's up to you. Your Kconfig entry should be exhaustive as far as supported HW goes. > > * in drivers/mfd/twl-core.c: > > - status = twl_init_irq(client->irq, pdata->irq_base, pdata- > > >irq_end); > > + status = twl_init_irq(client->irq, pdata->irq_base, > > + pdata->irq_end); > > > > Please remove it as it's unrelated to this patchset. > > > Ok > > * Same for the > > - ( (devgrp) << 13 | 1 << 12 | (grp) << 9 | (type2) << 7 \ > > + ((devgrp) << 13 | 1 << 12 | (grp) << 9 | (type2) << 7 \ > > > > lines from include/linux/i2c/twl4030.h > > > Ok > > * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? > > > twl_init_irq and twl_exit_irq is defined in twl4030-irq.c and called from > twl-core.c. Earlier twl4030-core.c had declaration too. You're now exporting those 2 routines from a include/linux/ header, and I still dont understand why. Cheers, Samuel. > > Cheers, > > Samuel. > > > > > > > Thanks and Regards, > > > Balaji T K > > > > -----Original Message----- > > > > From: Krishnamoorthy, Balaji T > > > > Sent: Thursday, August 06, 2009 2:28 PM > > > > To: sa...@linux.intel.com > > > > Cc: linux-omap@vger.kernel.org; t...@atomide.com; > > khil...@deeprootsystems.com; > > > > davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; > > > > sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- > > > > li...@fluff.org; broo...@opensource.wolfsonmicro.com; > > > > l...@slimlogic.co.uk; > > > > Krishnamoorthy, Balaji T > > > > Subject: RE: [RFC][PATCH 0/4] TWL6030 patch series > > > > > > > > Hi Samuel, > > > > > > > > Could you please add your comments on the following patch series. > > > > > > > > series 1 > > > > [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use > > > > [PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*. > > > > [PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic > > > > rtc > > > > [PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to > > > > make > > it > > > > generic reg > > > > > > > > series 2 dependent on series 1 > > > > [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 > > > > regulators > > > > [RFC][PATCH v2 3/4] OMAP4: PMIC: Add support for twl6030 regulators > > > > [RFC][PATCH v2 2/4] OMAP4: PMIC: Add support for twl6030 RTC > > > > [RFC][PATCH v2 1/4] OMAP4: PMIC: Add support for twl6030 irq framework > > > > > > > > Thanks and Regards, > > > > Balaji T K > > > > > > > > > -----Original Message----- > > > > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > > > > ow...@vger.kernel.org] On Behalf Of Krishnamoorthy, Balaji T > > > > > Sent: Monday, July 20, 2009 7:04 PM > > > > > To: linux-ker...@vger.kernel.org > > > > > Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; > > t...@atomide.com; > > > > > khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; > > Nayak, > > > > > Rajendra; sa...@openedhand.com; w...@iguana.be; > > timo.t.kokko...@nokia.com; > > > > ben- > > > > > li...@fluff.org; broo...@opensource.wolfsonmicro.com; > > l...@slimlogic.co.uk > > > > > Subject: [RFC][PATCH 0/4] TWL6030 patch series > > > > > > > > > > The upcoming TWL6030 is companion chip for OMAP4 like the current > > TWL4030 > > > > > for OMAP3. This patch series adds support for TWL6030 irq framework, > > > > > and > > > > > driver support for RTC and regulator. > > > > > > > > > > drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT > > status > > > > > registers, ack and clear mechanism has changed from > > twl4030,5030. > > > > > drivers/rtc/rtc-twl.c will support twl4030,twl5030, and also > > twl6030 rtc > > > > > drivers/regulator/twl-regulator.c will support twl regulators. > > > > > include/linux/i2c/twl.h will have TWL4030 and TWL6030 offsets > > selected > > > > > at compile time by CONFIG_TWL4030_CORE / > > > > > CONFIG_TWL6030_CORE > > > > > > > > > > These patches are generated against mainline 2.6.31-rc1 and has > > dependancy > > > > on > > > > > my 1st series[1]. > > > > > Patch list: > > > > > [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq > > framework > > > > > [RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC > > > > > [RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators > > > > > [RFC][PATCH 4/4] OMAP4: PMIC: Update TWL mfd driver to create > > twl6030 > > > > > regulators > > > > > > > > > > Needed board-* changes and defconfig changes will be done later.Please > > let > > > > me > > > > > know your feedback/suggestion on this patch series. > > > > > > > > > > Thanks and Regards, > > > > > Balaji T K > > > > > [1] http://marc.info/?l=linux-omap&m=124757921417187&w=2 > > > > > [PATCH 0/4] TWL patch series > > > > > -- > > > > > To unsubscribe from this list: send the line "unsubscribe linux-omap" > > > > > in > > > > > the body of a message to majord...@vger.kernel.org > > > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > > > -- > > Intel Open Source Technology Centre > > http://oss.intel.com/ > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
