On Thu, Sep 3, 2009 at 12:31 PM, Andy
Shevchenko<[email protected]> wrote:
> On Thu, Sep 3, 2009 at 12:17 PM, Artem Bityutskiy<[email protected]> wrote:
>> On Thu, 2009-09-03 at 12:06 +0300, Andy Shevchenko wrote:
>>> @@ -590,7 +589,7 @@ DSP_STATUS CMM_GetInfo(struct CMM_OBJECT *hCmmMgr,
>>> /* next node. */
>>> pCurNode = (struct CMM_MNODE
>>> *)LST_Next(pAltr->
>>> pInUseListHead,
>>> - (struct LST_ELEM *)pCurNode);
>>> + (struct list_head *) pCurNode);
>>
>> I do not completely agree with this change. Please do not put space
>> between the cast and the variable. The cast kind of belongs to the
>> variable, so it is nicer to have no space there.
> Partially code is written in way w/o spaces, partially in way with
> space. The style of whole driver is awful.
> Just for information, in our kernel:
> sh-3.2$ git grep -n 'list_head *)[^ ]' | wc
> 110 519 8630
> sh-3.2$ git grep -n 'list_head *) ' | wc
> 43 236 3345
Oh, wrong regexp :-)
sh-3.2$ git grep -n 'list_head \*) ' | wc
80 450 6440
sh-3.2$ git grep -n 'list_head \*)[^ ]' | wc
28 170 2202
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
