Hi Russell, From: ext Russell King <[email protected]> Subject: Re: [PATCH 9/10] omap mailbox: OMAP4 Mailbox Patch to change the IRQ flag from IRQF_DISABLED to IRQF_SHARED Date: Wed, 23 Sep 2009 11:58:15 +0200
> On Tue, Sep 22, 2009 at 08:05:09PM +0530, C.A, Subramaniam wrote: > > Currently, this facilitates both the tesla and ducati > > sides to request for the same irq through an > > omap_mbox_get() call. > > You're dropping IRQF_DISABLED - is this safe? Why was the original code > using it? Do you need IRQF_DISABLED|IRQF_SHARED ? I don't remember why IRQF_DISABLED was used and it might not be necessary from the beginning. Anyway it's not necessay now since there's no risk that other ISRs touch mailbox contents at least. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
