Tony, > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Tony Lindgren > Sent: Monday, October 19, 2009 12:12 PM > To: Shilimkar, Santosh > Cc: [email protected]; [email protected] > Subject: Re: [PATCH 08/14] omap: Use ioremap for omap4 L4 code > > * Shilimkar, Santosh <[email protected]> [091019 00:27]: > > Tony, > > > -----Original Message----- > > > From: Tony Lindgren [mailto:[email protected]] > > > Sent: Monday, October 19, 2009 5:54 AM > > > To: Shilimkar, Santosh > > > Cc: [email protected]; > [email protected] > > > Subject: Re: [PATCH 08/14] omap: Use ioremap for omap4 L4 code > > > > > > * Tony Lindgren <[email protected]> [091017 09:19]: > > > > * Shilimkar, Santosh <[email protected]> [091017 03:49]: > > > > > Thanks Tony for this ioremap series!! > > > > > > > > > > > -----Original Message----- > > > > > > From: Tony Lindgren [mailto:[email protected]] > > > > > > Sent: Saturday, October 17, 2009 5:16 AM > > > > > > To: [email protected] > > > > > > Cc: [email protected]; Shilimkar, Santosh > > > > > > Subject: Re: [PATCH 08/14] omap: Use ioremap for > omap4 L4 code > > > > > > > > > > > > * Tony Lindgren <[email protected]> [091016 16:42]: > > > > > > > Use ioremap for omap4 L4 code > > > > > > > > > > > > Santosh, can you please check and ack this patch? > > > > > > > > > > > > Especially some of the ioremap sizes may be wrong. > Also, this one > > > > > > I cannot boot test, so it's just compile tested. > > > > > > > > > > I have checked the patch and it looks all right > except few typo. Also > > > the scu_base is needed bit earlier. > > > > > > <snip> > > > > > > > > Here is the patch on top of ioremap series which > should fix above > > > mentioned things. With below patch + two serial related > patches the kernel > > > boots on OMAP4430. > > > > > > > > Great, will update. Thanks for taking the time to fix it! > > > > > > Here's this one updated with Santosh's fix merged in. > > V2 has one typo which I think I also missed in my patch. > > >+ /* Static mapping, never released */ > > >+ gic_cpu_base_addr = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512); > > >+ BUG_ON(!base); > > Should be BUG_ON(!gic_cpu_base_addr); > > OK, here's V3 of the patch.
Tony, > diff --git a/arch/arm/plat-omap/include/mach/entry-macro.S > b/arch/arm/plat-omap/include/mach/entry-macro.S > index abe0864..3bad928 100644 > --- a/arch/arm/plat-omap/include/mach/entry-macro.S > +++ b/arch/arm/plat-omap/include/mach/entry-macro.S > @@ -104,6 +104,8 @@ > > .endm > #else > +#define OMAP44XX_VA_GIC_CPU_BASE OMAP2_IO_ADDRESS(OMAP44XX_GIC_CPU_BASE) > + Shouldn't this define go with the ioremap aproach? > /* > * The interrupt numbering scheme is defined in the > * interrupt controller spec. To wit: Regards, Sergio > > Tony > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
