>-----Original Message----- >From: [email protected] >[mailto:[email protected]] On Behalf Of Pais, >Sent: Monday, October 26, 2009 4:40 PM >To: Pais, Allen; [email protected] >Subject: RE: [PATCH 1/2] Added board-3630.c file.
>> Signed-off-by: Allen Pais <[email protected]> >> --- >> arch/arm/mach-omap2/board-3630sdp.c | 188 >> +++++++++++++++++++++++++++++++++++ >> 1 files changed, 188 insertions(+), 0 deletions(-) create mode >> 100644 arch/arm/mach-omap2/board-3630sdp.c >> >> diff --git a/arch/arm/mach-omap2/board-3630sdp.c b/arch/arm/mach- >> omap2/board-3630sdp.c new file mode 100644 index 0000000..d3ddbd1 >> --- /dev/null >> +++ b/arch/arm/mach-omap2/board-3630sdp.c >> @@ -0,0 +1,188 @@ >> +/* >> + > >NAK. Could we follow the same issue with zoom2 -> break the keypad into a >Separate one and use it >instead? Same for all reused zoom2 components.. > >[Allen] Yes, we should do that. Not only for keypad but also >For display panel and touch screen so that sdp3630, zoom3 and >Zoom2 could use the same code, without having to duplicate >Code. We just got the same image for zoom3 boot on SDP3630 (after mach-type change) The peripheral set is almost >90% same: same keypad, same display, same RAM, same NAND. I see a good amount of re-use possible here. Here is how we could do it: Board-zoom2.c Split into: Board-zoom2.c Board-zoom-peripheral.c [reuse] 3630 zoom3 uses: Board-zoom3.c Board-zoom-peripheral.c [reuse] 3630 SDP uses: Board-3630sdp.c Board-zoom-peripheral.c [reuse] Will give a first pass at this split up and post patches. > >> + >> +static struct matrix_keymap_data board_map_data = { -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
