> From: [email protected] [mailto:[email protected]]
> Sent: Saturday, October 31, 2009 4:40 AM

> > @@ -60,6 +60,9 @@ struct dpll_data {
> >       void __iomem            *idlest_reg;
> >       u32                     autoidle_mask;
> >       u32                     freqsel_mask;
> > +     u32                     dco_sel_mask;
> > +     u32                     sd_div_mask;
> > +     u8                      jtype;
> >       u32                     idlest_mask;
> >       u8                      auto_recal_bit;
> >       u8                      recal_en_bit;
>
> Are the dco_sel_mask and sd_div_mask needed in the struct or is the jtype flag
> enough info?
> Could you use OMAP3630_PERIPH_DPLL_DCO_SEL_MASK and
> OMAP3630_PERIPH_DPLL_SD_DIV_MASK directly in omap3_noncore_dpll_program
> instead of
> dd->dco_sel_mask and sd_div_mask?

Could be done that way, seems a little better also to save structure space. To 
make quick patch I just followed style/spirit of existing coding.

It will be a couple weeks before I'm near a 3630 again to test any change.  I'm 
ok if anyone is able to adjust.

Regards
Richard W.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to